GH-48608: [Python] Fix interpolate actual values in Message.__repr__ f-string#48656
GH-48608: [Python] Fix interpolate actual values in Message.__repr__ f-string#48656rok merged 3 commits intoapache:mainfrom
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
|
@Aokizy2 looks great to me, please rename this PR to follow the recommended naming convention. |
|
|
|
@rustyconover OK,I've renamed this PR. |
|
Thanks finding this @rustyconover and for opening a PR @Aokizy2! |
|
I think the diff has too many formatting changes in it, can you have it not change so much existing code? |
|
sure,I'll change it |
|
Is it ok now? |
|
Thanks, that looks good @Aokizy2, will merge if CI passes. |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 727106f. There weren't enough matching historic benchmark results to make a call on whether there were regressions. The full Conbench report has more details. |
Rationale for this change
Message.__repr__showed format placeholders ({self.type}) instead of actual values.What changes are included in this PR?
Add missing
fprefix to f-string inMessage.__repr__(pyarrow/lib.pxi).Are these changes tested?
Yes: added test verifying string representation shows actual values.
Are there any user-facing changes?
Yes (bug fix):
str(message)now shows values liketype: RecordBatchinstead of placeholders.related to issue #48608